-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for updateStrategy in Logstash #7466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
UpdateStrategy: appsv1.StatefulSetUpdateStrategy{ | ||
Type: appsv1.RollingUpdateStatefulSetStrategyType, | ||
RollingUpdate: &appsv1.RollingUpdateStatefulSetStrategy{ | ||
MaxUnavailable: &intstr.IntOrString{ | ||
IntVal: 1, | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not from this PR but I am a bit confused by this test. Not sure what it actually verifies. It seems it it is just retrieving the Logstash resource again that we just put in as an expected object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It verifies the value of LogstashStatus is up-to-date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. But for the addition of the UpdateStrategy
a test would be more useful that verifies that the UpdateStrategy
specified in the Logstash resource is actually applied to the StatefulSet
that is being created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test is updated
Logstash adds
updateStrategy
in CRD which is a StatefulSetUpdateStrategyThe default type is "RollingUpdate"
sample resource