E2E tests fixes #734
Merged
E2E tests fixes #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkbay
requested review from
artemnikitin,
nkvoll,
pebrc,
sebgl and
thbkrkr
as code owners
pebrc
reviewed
May 6, 2019
| @@ -129,7 +129,8 @@ func (hc *ContinousHealthCheck) Start() { | |||
| defer cancel() | |||
| health, err := hc.esClient.GetClusterHealth(ctx) | |||
| if err != nil { | |||
| hc.AppendErr(err) | |||
| // TODO: Temporarily account only red clusters, see https://github.com/elastic/k8s-operators/issues/614 | |||
| //hc.AppendErr(err) | |||
There was a problem hiding this comment.
Should we use something like a red health budget instead? Allow the cluster to lose its green status for a maximum of x seconds maybe? Or if that sounds like a recipe for more flaky tests use a different metric like allow max n non-green observations?
pebrc
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix e2e tests, this PR:
keystore_test.gobecause it is flaky (see TestUpdateSecureSettings is flaky #733)