Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user http tls certificate watch leak #2975

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix user http tls certificate watch leak #2975

merged 1 commit into from
Apr 28, 2020

Conversation

barkbay
Copy link
Contributor

@barkbay barkbay commented Apr 28, 2020

This PR fixes a watch leak on custom HTTP TLS secrets.

I only updated the existing Enterprisearch unit test, other unit tests should be updated as part of #249

@barkbay barkbay added >bug Something isn't working v1.2.0 labels Apr 28, 2020
@barkbay barkbay mentioned this pull request Apr 28, 2020
Open
sebgl
sebgl approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@barkbay barkbay merged commit 2465556 into elastic:master Apr 28, 2020
@barkbay barkbay deleted the tls-watch-leak branch April 28, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebgl sebgl sebgl approved these changes

Assignees
No one assigned
Labels
>bug Something isn't working v1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barkbay @sebgl