-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webhook secret and ValidatingWebhookConfiguration certificate management #2126
Conversation
I have updated the comment, I just did a quick test and the user can switch from a "self-managed" certificates mode to a "cert manager" scenario. The existing Secret, even if there already are some certificates, is "adopted" by the certificate manager. I will create some documentation in a dedicated pr and update the existing one if we agree on the general idea proposed by this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. A few initial comments. Still trying to understand what are the trade offs of using a native client. Also want to give it a spin.
terminationGracePeriodSeconds: 10 | ||
volumes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is maybe overthinking it. I wonder if we want the secret to be in this file, because right now this yaml on its own will fail to deploy because the secret doesn't exist. You would need to deploy the webhook yaml also.
That might be a usability thing we can punt on in this PR though. I think right now most people will have the ability to deploy everything, and those that don't have the ability to edit yaml files. We might want to adjust in the future but this should work for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pr automatically fills the Secret and the ValidatingWebhookConfiguration of the webhook with some certificates.
A few notes:
TODO: