-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-namespace cache support #1995
Add multi-namespace cache support #1995
Conversation
I know in the past we discussed maybe wanting two separate flags since we chose the |
@@ -33,7 +33,7 @@ spec: | |||
containers: | |||
- name: e2e | |||
image: {{ .E2EImage }} | |||
imagePullPolicy: IfNotPresent | |||
imagePullPolicy: Always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with how E2EImage was populated. Were we reusing image names across test runs and so they were getting cached even if they changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image caching is a problem if you manually run the tests with uncommitted changes.
I kept the setting because it won't affect the normal CI runs (E2E image name is unique and will require a pull from the registry anyway).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may have introduced IfNotPresent
a while ago in order to run tests on Minikube. We didn't have a registry there, so we used to build the image in Minikube context. Meaning it was possible to use it, but not to pull it from Minikube.
The situation is different now, we do run a registry in Minikube if I remember correctly (hack/registry.sh
).
I agree with @anyasabo about not having both |
@@ -33,7 +33,7 @@ spec: | |||
containers: | |||
- name: e2e | |||
image: {{ .E2EImage }} | |||
imagePullPolicy: IfNotPresent | |||
imagePullPolicy: Always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may have introduced IfNotPresent
a while ago in order to run tests on Minikube. We didn't have a registry there, so we used to build the image in Minikube context. Meaning it was possible to use it, but not to pull it from Minikube.
The situation is different now, we do run a registry in Minikube if I remember correctly (hack/registry.sh
).
Regarding breaking changes: I think I would also vote for removing the singular Arguments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I agree with the small breakage since we are the ones who ship the operator yaml.
Uses the multi-namespace cache if the operator is provided with a list of namespaces to be managed. This would allow users to restrict the operator to a small set of namespaces.
For backward compatibility reasons,namespace
flag has been retained but it will be ignored if thenamespace-list
flag is provided.Also changes the E2E test runner to have a single operator for all E2E namespaces rather than an operator per namespace.
Fixes #405, #782