Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate xUnit XML with test results in the case of test fail #1816

Merged
merged 4 commits into from
Sep 30, 2019
Merged

Generate xUnit XML with test results in the case of test fail #1816

merged 4 commits into from
Sep 30, 2019

Conversation

artemnikitin
Copy link
Member

@artemnikitin artemnikitin commented Sep 27, 2019 •
edited
Loading

Original PR #1724 added generation of xUnit compatible XML for unit and integration but misses a bug. In the case if tests failed XML will not be generated. This PR fixes that

@artemnikitin artemnikitin added :ci Things related to Continuous Integration, automation and releases v1.0.0-beta1 labels Sep 27, 2019
@charith-elastic
Copy link
Contributor

There's some duplicated effort with #1806 😄

Any reason why we can't directly use gotestsum as I have done in #1806? I feel like it would be simpler to understand.

@artemnikitin
Copy link
Member Author

@charith-elastic Good catch, thanks. I will fix that.

@artemnikitin artemnikitin mentioned this pull request Sep 27, 2019
Closed
charith-elastic
charith-elastic approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@charith-elastic charith-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artemnikitin
Copy link
Member Author

artemnikitin commented Sep 27, 2019 •
edited
Loading

First failed integration test handled by generated XML and Jenkins 😃
https://devops-ci.elastic.co/job/cloud-on-k8s-pr/1496/testReport/junit/github/com_elastic_cloud-on-k8s_pkg_controller_license/TestReconcile/

@artemnikitin
Copy link
Member Author

jenkins test this please

1 similar comment
@artemnikitin
Copy link
Member Author

jenkins test this please

@artemnikitin
Copy link
Member Author

jenkins test this please

@artemnikitin artemnikitin merged commit 1fa6f5d into elastic:master Sep 30, 2019
@artemnikitin artemnikitin deleted the 1229-work-on-fail branch September 30, 2019 08:33
@artemnikitin artemnikitin mentioned this pull request Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charith-elastic charith-elastic charith-elastic approved these changes

Assignees
No one assigned
Labels
:ci Things related to Continuous Integration, automation and releases v1.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artemnikitin @charith-elastic