Fix handling of HTTP CA #1742
Merged
Fix handling of HTTP CA #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charith-elastic
force-pushed
the
ca-certs
branch
from
dcd5f71 to
021cd92
Compare
pebrc
approved these changes
Sep 19, 2019
| return nil, fmt.Errorf("expected an RSA private key but got %t", key) | ||
| } | ||
|
|
||
| return rsaKey, nil |
There was a problem hiding this comment.
Am I mistaken or are we missing unit tests for this? Maybe an opportunity to add one (or two)?
There was a problem hiding this comment.
The reason I didn't add any unit tests is because these functions are just thin wrappers over standard library functions. Happy to add tests if you think differently.
charith-elastic
force-pushed
the
ca-certs
branch
from
132f4d4 to
0c52466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details can be found in #1614.
Briefly, this PR does the following:
ca.crtkey in the secret as a signal to override the appropriate*.certificate_authoritiessetting of the associated stack application.Fixes #1614