Update zen2 settings only if there is no v6 master node #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing any zen2 API call (voting config exclusions), we checked if there is at least one v7+ master in the cluster in order to proceed. This is wrong because if the current master is a v6 node, the call will fail. In a cluster with mixed v6 -> v7 versions, the current master is supposed to be a v6 node. Zen2 APIs can be called once there is no more v6 node in the cluster, at which point the current master is a v7 node. For more context, see elastic#1281 (comment)
sebgl
added
justdoit
pebrc
approved these changes
Aug 19, 2019
operators/pkg/controller/elasticsearch/version/zen2/compatibility.go
Outdated
Show resolved
Hide resolved
pebrc
reviewed
Aug 19, 2019
|
Not sure if it is related to this PR but I managed to get five 6.x nodes and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing any zen2 API call (voting config exclusions), we checked if
there is at least one v7+ master in the cluster in order to proceed.
This is wrong because if the current master is a v6 node, the call will
fail.
In a cluster with mixed v6 -> v7 versions, the current master is
supposed to be a v6 node. Zen2 APIs can be called once there is no more
v6 node in the cluster, at which point the current master is a v7 node.
For more context, see
#1281 (comment)
This also adds a helper function to build pods for testing purposes.
Relates #1281.