Relax Elasticsearch validation hook failure policy #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebgl
approved these changes
Jul 25, 2019
barkbay
approved these changes
Jul 25, 2019
pebrc
added a commit
to pebrc/cloud-on-k8s
that referenced
this pull request
Jul 25, 2019
This was referenced Jul 25, 2019
pebrc
added a commit
that referenced
this pull request
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We relaxed the failure policy for the secret validation hook in #1305 but it occurred to me that it might make sense to do the same for Elasticsearch itself, so that users are not blocked in case of problems with the webhook service, which seem to occur more often than not.
Validations still run in any case inside the reconciliation loop so there is no danger of circumventing validations.