Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init Elasticsearch spec asciidoc #1174

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Init Elasticsearch spec asciidoc #1174

merged 2 commits into from
Jul 3, 2019

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Jul 1, 2019

  • Draft intro
  • Node configuration
  • HTTP settings & TLS SANs
  • Custom HTTP certificate

Parts of #1031.

@thbkrkr
Init Elastisearch spec asciidoc
5d8a099 
- Draft intro
- Node configuration
- HTTP settings & TLS SANs
- Custom HTTP certificate
sebgl
sebgl approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that's a good starting point 👍
I'd say let's try to merge asap so others can work their section on top of this?

docs/elasticsearch-spec.asciidoc
[id="{p}-elasticsearch-specification"]
== Elasticsearch Specification

There are a number of settings which need to be considered before going into production related to Elasticsearch but also to Kubernetes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence sounds a bit strange, @alaudazzi what do you think?

Copy link
Contributor Author

@thbkrkr thbkrkr Jul 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it sounds a bit odd. This comes from https://www.elastic.co/guide/en/elasticsearch/reference/current/important-settings.html ...
We agreed with @alaudazzi that she will make a global pass when we have covered all the settings.

docs/elasticsearch-spec.asciidoc Outdated Show resolved Hide resolved
@thbkrkr thbkrkr merged commit 9ab7870 into elastic:master Jul 3, 2019
@thbkrkr thbkrkr deleted the es-spec-asciidoc branch July 15, 2019 15:10
@thbkrkr thbkrkr changed the title Init Elastisearch spec asciidoc Init Elasticsearch spec asciidoc Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebgl sebgl sebgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thbkrkr @sebgl