Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operator.template.yaml #1130

Closed
wants to merge 1 commit into from
Closed

Conversation

trotro
Copy link

@trotro trotro commented Jun 21, 2019

Replacing all by global,namespace in the operator stateful set spec solves the issue #896

Replacing ```all``` by ```global,namespace``` in the operator stateful set spec solves the issue elastic#896
@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@artemnikitin
Copy link
Member

jenkins test this please

@pebrc
Copy link
Collaborator

pebrc commented Jun 23, 2019

Thanks for your PR @trotro Unfortunately I think that we don't want to change the default here at this time. I believe we still want to have the webhook turned on by default because it gives valuable immediate feedback to users as we run validations on the submitted resources there. If we have problems with the webhook I think we should try to fix them first. I would see webhook removal therefore as a measure of last resort only.

@thbkrkr
Copy link
Contributor

thbkrkr commented Jul 3, 2019

Thanks for your contribution but like @pebrc said in the last comment, your proposal is more a solution of last resort. Here is why I close the PR for the moment.

@thbkrkr thbkrkr closed this Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants