Standard might not be the default storage class #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be-the-default-storage-class
barkbay
requested review from
artemnikitin,
idanmo,
nkvoll,
pebrc,
sebgl and
thbkrkr
as code owners
sebgl
reviewed
Jun 12, 2019
| return reflect.DeepEqual(claim.Spec.StorageClassName, candidate.Spec.StorageClassName) | ||
| if claim.Spec.StorageClassName == nil { | ||
| // volumeClaimTemplate has no storageClass set | ||
| return true |
There was a problem hiding this comment.
not sure I understand why we return true here? I read it as "if there is no storage class requested, then the candidate PV is compatible" which sounds wrong?
There was a problem hiding this comment.
Hmm I guess we have no way of knowing what is the "default" storage class on a given cluster, so we fallback to anything?
There was a problem hiding this comment.
Maybe we should get that comment a bit more explicit:
// volumeClaimTemplate has no storageClass set: it should use the k8s cluster default
// since we don't know that default, we fallback to reusing any available volume
// from the same cluster (whatever the storage class actually is)
sebgl
approved these changes
Jun 12, 2019
sebgl
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standardmight not be the default storage class, or there may be no storage class at all.In that case we should not try to compare the storage class and return
true.