Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kibana configuration #1030

Merged
merged 6 commits into from
Jun 10, 2019

Conversation

nkvoll
Copy link
Member

@nkvoll nkvoll commented Jun 8, 2019

Any YAML here ends up in kibana.yml.

Example usage:

apiVersion: kibana.k8s.elastic.co/v1alpha1
kind: Kibana
metadata:
  name: kibana-sample
spec:
  version: "7.1.0"
  nodeCount: 1
  elasticsearchRef:
    name: "elasticsearch-sample"
  config:
    xpack.security.sessionTimeout: 600000

Closes #740

nkvoll added 2 commits June 8, 2019 22:38
Any YAML here ends up in `kibana.yml`.

Example usage:

```yaml
apiVersion: kibana.k8s.elastic.co/v1alpha1
kind: Kibana
metadata:
  name: kibana-sample
spec:
  version: "7.1.0"
  nodeCount: 1
  elasticsearchRef:
    name: "elasticsearch-sample"
  config:
    xpack.security.sessionTimeout: 600000
```

Closes: elastic#740
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr
Copy link
Contributor

thbkrkr commented Jun 10, 2019

Do we want to let the user be able to override what is defined by default? If yes, we need to reverse the config in the merge.

Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkvoll nkvoll merged commit 0a760c9 into elastic:master Jun 10, 2019
@nkvoll nkvoll deleted the support-kibana-config branch June 10, 2019 13:22
@pebrc pebrc added >feature Adds or discusses adding a feature to the product v0.9.0 labels Jul 19, 2019
@pebrc pebrc changed the title Add a custom config parameter to the Kibana spec. Add support for Kibana configuration Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature Adds or discusses adding a feature to the product v0.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Kibana configuration
4 participants