Consider more defaulted values when comparing Services for reconciliation #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkvoll
requested review from
artemnikitin,
barkbay,
idanmo,
pebrc,
sebgl and
thbkrkr
as code owners
nkvoll
force-pushed
the
consider-potential-defaulted-values-when-comparing-services
branch
from
c602bad to
ab2696e
Compare
thbkrkr
approved these changes
Jun 6, 2019
nkvoll
deleted the
consider-potential-defaulted-values-when-comparing-services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's some more values that may be defaulted by the API server we should be aware of for comparison purposes.