-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assume all swap memory is free on values overflow #9383
Conversation
There have been reports about user swap memory being a value that looks like an overflow. At the moment used swap memory is calculated as the value of total memory minus the free memory, so this means that free memory is bigger than total in some cases. This isn't possible in principle. Assume that no swap is being used if that happens.
Pinging @elastic/infrastructure |
CHANGELOG.asciidoc
Outdated
@@ -38,6 +38,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha1...master[Check the HEAD d | |||
- Fix autodiscover configurations stopping when metadata is missing. {pull}8851[8851] | |||
- Log events at the debug level when dropped by encoding problems. {pull}9251[9251] | |||
- Refresh host metadata in add_host_metadata. {pull}9359[9359] | |||
- Handle cases of free swap being bigger than total swap by assuming no swap is being used. {issue}6271[6271] {pull}[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You haven't written the pull number. Maybe I'd add the module involved too
Thanks for the reviews, changes addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just minor comment on the log message. Stumbled over the Odd
part.
Co-Authored-By: jsoriano <jaime.soriano@elastic.co>
c5b0e4c
to
c13c44c
Compare
There have been reports about user swap memory being a value that looks like an overflow. At the moment used swap memory is calculated as the value of total memory minus the free memory, so this means that free memory is bigger than total in some cases. This isn't possible in principle. Assume that no swap is being used if that happens. (cherry picked from commit 7d9b2e3)
There have been reports about user swap memory being a value that looks like an overflow. At the moment used swap memory is calculated as the value of total memory minus the free memory, so this means that free memory is bigger than total in some cases. This isn't possible in principle. Assume that no swap is being used if that happens. (cherry picked from commit 7d9b2e3)
There have been reports about user swap memory being a value that looks
like an overflow. At the moment used swap memory is calculated as the
value of total memory minus the free memory, so this means that free
memory is bigger than total in some cases. This isn't possible in
principle. Assume that no swap is being used if that happens.
Closes #6271