Build docker images when building packages #8898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
:Packaging
in progress
jsoriano
changed the title
andrewkroh
reviewed
Nov 2, 2018
houndci-bot
reviewed
Nov 4, 2018
jsoriano
force-pushed
the
mage-package-docker
branch
from
ef06547
to
ae4239a
Compare
jsoriano
force-pushed
the
mage-package-docker
branch
from
4c3c9e4
to
d72283c
Compare
andrewkroh
reviewed
Nov 6, 2018
jsoriano
added
review
and removed
in progress
|
@andrewkroh @graphaelli some sanity tests are still pending, but I think this is ready for a first review, it'd be nice if you could give it another look. Thanks! |
graphaelli
reviewed
Nov 7, 2018
graphaelli
reviewed
Nov 7, 2018
andrewkroh
reviewed
Nov 8, 2018
| @@ -457,3 +502,122 @@ func readZip(zipFile string) (*packageFile, error) { | |||
|
|
|||
| return p, nil | |||
| } | |||
|
|
|||
| func readDocker(dockerFile string) (*packageFile, *dockerInfo, error) { | |||
graphaelli
approved these changes
Nov 12, 2018
andrewkroh
approved these changes
Nov 13, 2018
|
@andrewkroh thanks for the review, I have addressed your comments. Regarding additional tests, it could be possible, we could maybe modify system tests to use docker, so the docker image is also tested with them, but I don't have any plan for it at the moment. |
This was referenced Nov 13, 2018
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Dec 7, 2018
Include generation of docker images in the process of building the rest of released packages by extending `mage package`. (cherry picked from commit 9294384)
jsoriano
added a commit
that referenced
this pull request
Dec 8, 2018
…uilding packages (#9433) Include generation of docker images in the process of building the rest of released packages by extending `mage package`. (#8898) (cherry picked from commit 9294384) Tag container images with snapshot information (#9063) (cherry picked from commit 1dd4fbf) * Compress docker artifacts with gzip (#9223) (cherry picked from commit 675f2b0) Co-authored-by: Gil Raphaelli <g@raphaelli.com>
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Feb 27, 2019
… docker images when building packages (elastic#9433) Include generation of docker images in the process of building the rest of released packages by extending `mage package`. (elastic#8898) (cherry picked from commit 9294384) Tag container images with snapshot information (elastic#9063) (cherry picked from commit 1dd4fbf) * Compress docker artifacts with gzip (elastic#9223) (cherry picked from commit 675f2b0) Co-authored-by: Gil Raphaelli <g@raphaelli.com>
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
Include generation of docker images in the process of building the rest of released packages by extending `mage package`.
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
… docker images when building packages (elastic#9433) Include generation of docker images in the process of building the rest of released packages by extending `mage package`. (elastic#8898) (cherry picked from commit 9294384) Tag container images with snapshot information (elastic#9063) (cherry picked from commit 1dd4fbf) * Compress docker artifacts with gzip (elastic#9223) (cherry picked from commit 675f2b0) Co-authored-by: Gil Raphaelli <g@raphaelli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include generation of docker images in the process of building the rest of released packages by extending
mage package. Ideally it could be extended to build images for windows too.Dockerfile, entry point templates and default beats configurations based on current ones.
Pending:
docker saveor similarheartbeat-elastic🤔 it should beheartbeatas other beatsInstall libsystemd in journalbeat(systemd-libs already installed in centos:7 base image)