Add operating system from vsphere to 'os' field #8638
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| @@ -141,6 +141,7 @@ func (m *MetricSet) Fetch() ([]common.MapStr, error) { | |||
| event := common.MapStr{ | |||
| "host": vm.Summary.Runtime.Host.Value, | |||
| "name": vm.Summary.Config.Name, | |||
| "os": vm.Summary.Config.GuestFullName, | |||
There was a problem hiding this comment.
This file needs to be formatted with gofmt.
There was a problem hiding this comment.
Thanks for the contribution. There are two additional things that this needs:
- Add
osto https://github.com/elastic/beats/blob/master/metricbeat/module/vsphere/virtualmachine/_meta/fields.yml. Then runmake updatefrom themetricbeatdir. - Add a line to CHANGELOG.asciidoc mentioning this change under the "added" section for Metricbeat.
|
jenkins, test this |
|
Anything need to be done to merge? |
|
@rfalias sorry for keeping it so long. Could you update the branch again with master and run |
| @@ -128,7 +128,48 @@ func (m *MetricSet) Fetch(reporter mb.ReporterV2) error { | |||
|
|
|||
| for _, vm := range vmt { | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
expected statement, found '<<' (and 3 more errors)
|
@rfalias there are some leftovers from the merge, could you check it? Tell us if you need any help with this. |
Add operating system from vsphere to 'os' field