add mongodb OP_MSG (2013) #8594

pohzipohzi · 2018-10-06T03:26:23Z

this fixes #6191

elasticmachine · 2018-10-06T03:26:24Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

ghost · 2019-01-05T08:47:41Z

Hi @pohzipohzi, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

ghost · 2019-01-05T08:47:41Z

Hi @pohzipohzi, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

pohzipohzi · 2019-01-05T15:42:16Z

@adriansr @cwurm any update on this?

adriansr · 2019-01-08T16:37:57Z

It looks good. However, the issue is the same as with #6440, we would like to have some basic tests for this.

Something like loading a PCAP with the new opcodes and checking that the emitted events are fine. There's a lot of examples in packetbeat, like this one https://github.com/elastic/beats/blob/master/packetbeat/tests/system/test_0001_mysql_spaces.py

adriansr · 2019-02-18T15:49:39Z

@pohzipohzi will you be able to add that test?

adriansr · 2019-02-18T22:29:23Z

CHANGELOG.asciidoc

@@ -106,7 +106,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d

 *Packetbeat*

- Add support for mongodb opcode 2013 (OP_MSG). {issue}6191[6191] {pull}8594[8594]


You've lost your changes to CHANGELOG.asciidoc while merging.

Note that now we use CHANGELOG.next.asciidoc for unreleased functionality, so you should add it there.

pohzipohzi · 2019-02-19T23:09:29Z

@adriansr sorry for taking so long to get back to you. Honestly I haven't touched this project in some time and I'm having some trouble setting up my environment to run python related tests. I will be a little busy this week but I do intend to add the test by next week or so

houndci-bot · 2019-03-27T23:54:31Z

packetbeat/flows/worker.go

@@ -38,7 +38,7 @@ type flowsProcessor struct {
 }

 var (
-	ErrInvalidTimeout = errors.New("timeout must not <= 1s")
+	ErrInvalidTimeout = errors.New("timeout must be >= 1s")


exported var ErrInvalidTimeout should have comment or be unexported

houndci-bot · 2019-03-27T23:54:31Z

metricbeat/module/ceph/cluster_status/cluster_status_test.go

@@ -96,22 +100,22 @@ func TestFetchEventContents(t *testing.T) {
 	assert.EqualValues(t, 2872860672, pgInfo["used_bytes"])

 	//check pg_state info
-	pg_stateInfo := events[1]["pg_state"].(common.MapStr)
+	pg_stateInfo := events[1].MetricSetFields["pg_state"].(common.MapStr)


don't use underscores in Go names; var pg_stateInfo should be pgStateInfo

houndci-bot · 2019-03-27T23:54:31Z

x-pack/metricbeat/module/aws/s3_request/s3_request_integration_test.go

+
+// +build integration
+
+package s3_request


don't use an underscore in package name

houndci-bot · 2019-03-27T23:54:31Z

x-pack/metricbeat/module/aws/s3_request/s3_request.go

+// or more contributor license agreements. Licensed under the Elastic License;
+// you may not use this file except in compliance with the Elastic License.
+
+package s3_request


don't use an underscore in package name

houndci-bot · 2019-03-27T23:54:32Z

x-pack/metricbeat/module/aws/s3_request/data.go

+// or more contributor license agreements. Licensed under the Elastic License;
+// you may not use this file except in compliance with the Elastic License.
+
+package s3_request


don't use an underscore in package name

houndci-bot · 2019-03-27T23:54:33Z

x-pack/filebeat/input/netflow/decoder/fields/field.go

@@ -20,12 +20,20 @@ type Field struct {

 type FieldDict map[Key]*Field

-func RegisterFields(dict FieldDict) error {
+func RegisterGlobalFields(dict FieldDict) error {


exported function RegisterGlobalFields should have comment or be unexported

houndci-bot · 2019-03-27T23:54:34Z

x-pack/filebeat/input/netflow/decoder/fields/field.go

@@ -6,7 +6,7 @@ package fields

 import "fmt"

-var Fields = FieldDict{}
+var GlobalFields = FieldDict{}


exported var GlobalFields should have comment or be unexported

houndci-bot · 2019-03-27T23:54:34Z

libbeat/publisher/processing/default.go

+
+// WithBeatMeta adds beat meta information as builtin fields to a processing pipeline.
+// The `key` parameter defines the field to be used.
+func WithBeatMeta(key string) modifier {


exported func WithBeatMeta returns unexported type processing.modifier, which can be annoying to use

houndci-bot · 2019-03-27T23:54:34Z

libbeat/publisher/processing/default.go

+}
+
+// WithECS modifier adds `ecs.version` builtin fields to a processing pipeline.
+var WithECS modifier = WithFields(common.MapStr{


should omit type modifier from declaration of var WithECS; it will be inferred from the right-hand side

houndci-bot · 2019-03-27T23:54:34Z

libbeat/publisher/processing/default.go

+}
+
+// WithFields creates a modifier with the given default builtin fields.
+func WithFields(fields common.MapStr) modifier {


exported func WithFields returns unexported type processing.modifier, which can be annoying to use

pohzipohzi · 2019-03-28T00:14:04Z

Closing and continuing in #11500

pohzipohzi added 2 commits October 6, 2018 11:23

add mongodb op_msg 2013

df1f925

Merge branch 'master' into opc

e5928c0

pohzipohzi and others added 8 commits October 6, 2018 11:31

add changelog

40c5ea7

add changelog

5a3e804

Merge remote-tracking branch 'upstream/master'

f58e595

Merge remote-tracking branch 'upstream/master'

adafb90

Merge branch 'master' into opc

4f2c1e8

Merge branch 'master' of github.com:pohzipohzi/beats

a5c84fd

Merge remote-tracking branch 'upstream/master'

3bf2f98

Merge branch 'master' into opc

cd8ee82

pohzipohzi requested a review from a team as a code owner January 5, 2019 08:47

pohzipohzi added 2 commits January 5, 2019 16:52

update doc

63298d3

fix merge error

9b3af92

adriansr self-assigned this Feb 18, 2019

merge master

9e3b0b8

adriansr reviewed Feb 18, 2019

View reviewed changes

pohzipohzi and others added 2 commits February 20, 2019 06:15

add changelog

89fd465

update git user config

63b4492

merge master

5874d39

pohzipohzi requested a review from a team as a code owner February 25, 2019 16:09

poh added 3 commits March 26, 2019 06:56

Merge branch 'master' into opc

9e12f0a

remove test

c3965c3

trigger cla

dfb8ea9

pohzipohzi added 4 commits March 26, 2019 07:41

trigger cla

f4e2725

trigger cla

804f53b

add pcap test

029cfbe

run autopep8

4c512a4

pohzipohzi requested review from a team as code owners March 27, 2019 23:53

houndci-bot reviewed Mar 27, 2019

View reviewed changes

pohzipohzi mentioned this pull request Mar 28, 2019

add mongodb OP_MSG (2013) #11500

Merged

pohzipohzi closed this Mar 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add mongodb OP_MSG (2013) #8594

add mongodb OP_MSG (2013) #8594

pohzipohzi commented Oct 6, 2018

elasticmachine commented Oct 6, 2018

ghost commented Jan 5, 2019

ghost commented Jan 5, 2019

pohzipohzi commented Jan 5, 2019

adriansr commented Jan 8, 2019 •

edited

Loading

adriansr commented Feb 18, 2019 •

edited

Loading

adriansr Feb 18, 2019 •

edited

Loading

pohzipohzi commented Feb 19, 2019

houndci-bot Mar 27, 2019

houndci-bot Mar 27, 2019

houndci-bot Mar 27, 2019

houndci-bot Mar 27, 2019

houndci-bot Mar 27, 2019

houndci-bot Mar 27, 2019

houndci-bot Mar 27, 2019

houndci-bot Mar 27, 2019

houndci-bot Mar 27, 2019

houndci-bot Mar 27, 2019

pohzipohzi commented Mar 28, 2019

		@@ -106,7 +106,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d

		Packetbeat

		- Add support for mongodb opcode 2013 (OP_MSG). {issue}6191[6191] {pull}8594[8594]

add mongodb OP_MSG (2013) #8594

add mongodb OP_MSG (2013) #8594

Conversation

pohzipohzi commented Oct 6, 2018

elasticmachine commented Oct 6, 2018

ghost commented Jan 5, 2019

ghost commented Jan 5, 2019

pohzipohzi commented Jan 5, 2019

adriansr commented Jan 8, 2019 • edited Loading

adriansr commented Feb 18, 2019 • edited Loading

adriansr Feb 18, 2019 • edited Loading

Choose a reason for hiding this comment

pohzipohzi commented Feb 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pohzipohzi commented Mar 28, 2019

adriansr commented Jan 8, 2019 •

edited

Loading

adriansr commented Feb 18, 2019 •

edited

Loading

adriansr Feb 18, 2019 •

edited

Loading