[Filebeat] Package x-pack modules in the Elastic-licensed distribution #8403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the packaging scripts to copy modules from x-pack/filebeat into Elastic-licensed packages.
adriansr
added
in progress
houndci-bot
reviewed
Sep 24, 2018
| var modulesDirGenerated = filepath.Clean("build/packaging/modules") | ||
| var modulesDirGeneratedOSS = filepath.Clean("build/packaging/modules-oss") | ||
| var modulesDirGeneratedXPack = filepath.Clean("build/packaging/modules-x-pack") | ||
| var modules_D_DirGeneratedXpack = filepath.Clean("build/packaging/modules.d-x-pack") |
There was a problem hiding this comment.
don't use underscores in Go names; var modules_D_DirGeneratedXpack should be modulesDDirGeneratedXpack
8 tasks
|
There's an issue in the Jenkins PR packaging job at https://beats-ci.elastic.co/job/elastic+beats+pull-request+package/2/console. I guess it's because the module hasn't been added yet. |
|
Right, should account for this |
|
I think this will mostly be obsoleted by #8615 once it merges in. Should we close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the packaging scripts to copy modules from
x-pack/filebeatinto Elastic-licensed packages.TODO: Update fields.yml