Update geoip data for test_module #8401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
module
Filebeat
kvch
approved these changes
Sep 24, 2018
ruflin
reviewed
Sep 24, 2018
| "haproxy.backend_name": "docs_microservice", | ||
| "haproxy.http.request.raw_request_line": "GET /component---src-pages-index-js-4b15624544f97cf0bb8f.js HTTP/1.1", | ||
| "haproxy.http.request.captured_cookie": "-", | ||
| "@timestamp": "2018-07-30T09:03:52.726Z", |
There was a problem hiding this comment.
Looks like we should make sure the output fields are always sorted the same way.
There was a problem hiding this comment.
When GENERATE=1is used to generate these files, they are alphabetically sorted.
json.dump(objects, f, indent=4, sort_keys=True)
This file came from community, not sure how it was generated then, but it should be fine in that sense from now on.
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 24, 2018
(cherry picked from commit 2fb5984)
jsoriano
added
v6.5.0
and removed
needs_backport
This was referenced Sep 24, 2018
jsoriano
added a commit
that referenced
this pull request
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workarounds #8400 by now