Update Elasticsearch module examples to show http in the URL #8226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
added
docs
review
needs_backport
dedemorton
commented
Sep 5, 2018
| @@ -71,7 +71,7 @@ Example config: | |||
| [source,yaml] | |||
| ---- | |||
| setup.kibana.host: "192.0.2.255:5601" | |||
| setup.kibana.protocol: "https" | |||
| setup.kibana.protocol: "http" | |||
There was a problem hiding this comment.
This change wasn't really necessary, but I figured it might be better to show this variation (when protocol is specified) with http.
ycombinator
approved these changes
Sep 6, 2018
|
CI failures are unrelated. 1 failure has to do with jenkins not being able to upload stuff to GCP at the end of the build and the other failure is a flaky test: #8208. |
dedemorton
removed
the
needs_backport
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Oct 17, 2018
dedemorton
added a commit
that referenced
this pull request
Oct 18, 2018
…8478) (#8529) * Clarify support for ssl options for modules (#7967) * Clarify support for ssl options for modules * Change example to show http module * Update Elasticsearch module examples to show http in the URL (#8226) * Improve reference docs that describe how to set options dynamically (#8290) * Improve Elasticsearch output docs about indices, pipelines, and keys settings * Updates from review * Change setting name from mapping to mappings * Remove note to reviewer * Fix conditional coding (#8446) * Suppress dashboard info when dashboards aren't available (#8395) * Clarify add_docker_metadata docs (#8478)
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Oct 18, 2018
dedemorton
added a commit
that referenced
this pull request
Oct 19, 2018
…8478) (#8528) * Clarify support for ssl options for modules (#7967) * Clarify support for ssl options for modules * Change example to show http module * Update Elasticsearch module examples to show http in the URL (#8226) * Improve reference docs that describe how to set options dynamically (#8290) * Improve Elasticsearch output docs about indices, pipelines, and keys settings * Updates from review * Change setting name from mapping to mappings * Remove note to reviewer * Fix conditional coding (#8446) * Suppress dashboard info when dashboards aren't available (#8395) * Clarify add_docker_metadata docs (#8478)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…tic#8290 elastic#8395 elastic#8446 elastic#8478) (elastic#8528) * Clarify support for ssl options for modules (elastic#7967) * Clarify support for ssl options for modules * Change example to show http module * Update Elasticsearch module examples to show http in the URL (elastic#8226) * Improve reference docs that describe how to set options dynamically (elastic#8290) * Improve Elasticsearch output docs about indices, pipelines, and keys settings * Updates from review * Change setting name from mapping to mappings * Remove note to reviewer * Fix conditional coding (elastic#8446) * Suppress dashboard info when dashboards aren't available (elastic#8395) * Clarify add_docker_metadata docs (elastic#8478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6115
I've updated the examples by removing
protocolfrom the examples except where we specifically describe theprotocoloption.