Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields renamed on redis 5.0 #8167

Merged
merged 5 commits into from
Sep 3, 2018
Merged

Fields renamed on redis 5.0 #8167

merged 5 commits into from
Sep 3, 2018

Conversation

jsoriano
Copy link
Member

Some fields are renamed on future redis 5.0, use the new terminology on
these fields and deprecate the old ones. While old fields are not
removed, both are filled with the same value.

Tests executed also on redis 4 and 5.

Continues with #7983

Some fields are renamed on future redis 5.0, use the new terminology on
these fields and deprecate the old ones. While old fields are not
removed, both are filled with the same value.

Tests executed also on redis 4 and 5.
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! it will need a changelog entry, also, some tests are failing, looks legit

@jsoriano
Copy link
Member Author

jenkins, test this again please

@jsoriano jsoriano added the needs_backport PR is waiting to be backported to other branches. label Sep 3, 2018
@jsoriano jsoriano merged commit b5f225f into elastic:master Sep 3, 2018
@jsoriano jsoriano deleted the redis-5.0 branch September 3, 2018 11:20
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 3, 2018
Some fields are renamed on future redis 5.0, use the new terminology on
these fields and deprecate the old ones. While old fields are not
removed, both are filled with the same value.

Tests executed also on redis 4 and 5.

(cherry picked from commit b5f225f)
@jsoriano jsoriano added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Sep 3, 2018
jsoriano added a commit that referenced this pull request Sep 3, 2018
Some fields are renamed on future redis 5.0, use the new terminology on
these fields and deprecate the old ones. While old fields are not
removed, both are filled with the same value.

Tests executed also on redis 4 and 5.

(cherry picked from commit b5f225f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants