Add a different doc helper for http and tls configurations #8159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
force-pushed
the
metricbeat-modules-doc-http-ssl
branch
from
9246411 to
fff01e8
Compare
jsoriano
added
the
needs_backport
jsoriano
changed the title
jsoriano
force-pushed
the
metricbeat-modules-doc-http-ssl
branch
2 times, most recently
from
3581069 to
b2cf05b
Compare
exekias
approved these changes
Aug 30, 2018
exekias
previously requested changes
Aug 30, 2018
| @@ -4,7 +4,7 @@ | |||
| Apache HTTPD server metricsets collected from the Apache web server. | |||
| short_config: false | |||
| release: ga | |||
| settings: ["ssl"] | |||
| settings: ["ssl", "http""] | |||
jsoriano
force-pushed
the
metricbeat-modules-doc-http-ssl
branch
from
b2cf05b to
5292ddf
Compare
jsoriano
dismissed
exekias’s stale review
Requested changes were addressed, this is ready for another review.
exekias
approved these changes
Sep 19, 2018
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 20, 2018
) (cherry picked from commit 4db5f0a)
jsoriano
added
v6.5.0
and removed
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 20, 2018
) (cherry picked from commit 4db5f0a)
jsoriano
added a commit
that referenced
this pull request
Sep 20, 2018
jsoriano
added a commit
that referenced
this pull request
Sep 20, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
) (elastic#8372) (cherry picked from commit 613cb6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules support TLS, but not HTTP (currently I think that only
mongodb, butmysql,postgresqland others may need to be revisited), but we use the same doc text for both.This change adds the possibility of using the TLS text separatedly by using two different
settingstags:httpand/orssl.