Beatless initial PR #7837

ph · 2018-08-01T20:27:03Z

Add a new beat inside the x-pack folder under the Elastic License, this is minimal requirement changes to have a build and a test running, no functionality is in.

make check fails because of make fmt complaining about the license, to fix the issue with the check we need to get elastic/go-licenser#15 merged.

Checkout the code and running make and make test will work.

NOTES TO REVIEWERS:

This PR target a feature branch called feature/beatless
This PR doesn't include beatless in the build all package yet, we will leverage work from X-Pack binaries #7783

Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running.

houndci-bot · 2018-08-01T20:27:12Z

x-pack/beatless/config/config.go

+type Config struct {
+}
+
+var DefaultConfig = Config{}


exported var DefaultConfig should have comment or be unexported

ruflin · 2018-08-02T13:22:04Z

x-pack/beatless/_meta/kibana.generated/5/index-pattern/beatless.json

@@ -0,0 +1,6 @@
+{


we normally don't check in index patterns.

ruflin · 2018-08-02T13:23:01Z

x-pack/beatless/data/meta.json

@@ -0,0 +1 @@
+{"uuid":"5c255ec6-8c55-418c-bc62-45bf3d411ed6"}


Data directory should be ignored.

ruflin · 2018-08-02T13:23:14Z

x-pack/beatless/fields.yml

@@ -0,0 +1,220 @@
+


fields.yml should be ignored

ph · 2018-08-02T13:51:46Z

@ruflin @kvch updated with first reviews comments.

urso · 2018-08-02T15:56:07Z

Does make check check the license header is the correct one? E.g. only AL2 license heaader outside of x-pack and not AL2 inside of x-pack directory.

ph · 2018-08-02T16:22:30Z

Not yet I was waiting for @exekias PR to get merged.

On Thu, Aug 2, 2018 at 11:58 AM Steffen Siering ***@***.***> wrote: Does make check check the license header is the correct one? E.g. only AL2 license heaader outside of x-pack and not AL2 inside of x-pack directory. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7837 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAACgEEMiHUgnomyIFqQOWXt5c1Alr6oks5uMyGigaJpZM4VrL0i> .

-- ph

kvch · 2018-08-02T18:41:52Z

Could you provide an example serverless.yml file?

andrewkroh · 2018-08-02T21:10:06Z

x-pack/beatless/magefile.go

+)
+
+func init() {
+	mage.SetBuildVariableSources(mage.DefaultBeatBuildVariableSources)


Is this line required? (Since it's in our repo hopefully it just works without setting this.)

andrewkroh · 2018-08-02T21:10:50Z

x-pack/beatless/magefile.go

+	start := time.Now()
+	defer func() { fmt.Println("package ran for", time.Since(start)) }()
+
+	mage.UseCommunityBeatPackaging()


That's probably not right. I guess this needs something that does not exist that only loads the x-pack package specs.

ph · 2018-08-03T00:09:27Z

Could you provide an example serverless.yml file?

@kvch There is no need to do that in that PR since there is no config validation, it's just the skeleton project to get going.

ph · 2018-08-03T00:14:55Z

@andrewkroh I've removed the line in question, but I am pretty green with the build magefile build system so it's certainly wrong.

mage build and mage crossbuild appear to be working in the beatless directory.

kvch · 2018-08-03T07:35:29Z

@ph Sorry, I didn't express myself properly. Are we going to provide an example serverless.yml for users?

ph · 2018-08-03T12:25:38Z

@kvch Oops sorry, Yes we will include one but since this PR doesn't have any config handling it's currently empty and is located at x-pack/beatless/beatless.yml. Just a note we have decided to go with beatless and not serverless, with all the internal name changes it is confusing.

Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.

ph · 2018-08-03T14:44:45Z

This PR need the changes of #7783 to make sure we correctly compile the new beat.

ph · 2018-08-03T14:47:19Z

@andrewkroh @kvch @urso I think we can merge this as is, so I can rebase followup PRs on top of it. Concerning the development strategy I was looking into using a feature branch instead of merging directly to master until we have a working alpha. WDYT?

* Beatless initial PR Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running. Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.

Beatless initial PR

6e26e1e

Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running.

ph added the in progress Pull request is currently in progress. label Aug 1, 2018

houndci-bot reviewed Aug 1, 2018

View reviewed changes

ph added the Functionbeat label Aug 1, 2018

ph added 3 commits August 1, 2018 16:33

Configure Travis for beatless

834d119

Wrong license header

80e409f

hound complains

b43e3c7

ph added review and removed in progress Pull request is currently in progress. labels Aug 1, 2018

ph changed the base branch from master to feature/beatless August 1, 2018 20:35

ph mentioned this pull request Aug 1, 2018

X-Pack binaries #7783

Merged

kvch assigned kvch and unassigned kvch Aug 2, 2018

kvch self-requested a review August 2, 2018 08:19

ruflin reviewed Aug 2, 2018

View reviewed changes

x-pack/beatless/fields.yml Outdated

@@ -0,0 +1,220 @@

Copy link

Contributor

ruflin Aug 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fields.yml should be ignored

update ignored fields

23b9089

missing license

48c7dad

andrewkroh reviewed Aug 2, 2018

View reviewed changes

remove useless lines

b53eb26

License check

ffa6efe

Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.

urso merged commit c4df1be into elastic:feature/beatless Aug 6, 2018

ph mentioned this pull request Aug 6, 2018

[Meta] Add FunctionBeat to run beat on serverless infrastructure #7880

Closed

42 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Beatless initial PR #7837

Beatless initial PR #7837

ph commented Aug 1, 2018 •

edited

Loading

houndci-bot Aug 1, 2018

ruflin Aug 2, 2018

ruflin Aug 2, 2018

ruflin Aug 2, 2018

ph commented Aug 2, 2018

urso commented Aug 2, 2018

ph commented Aug 2, 2018 via email

kvch commented Aug 2, 2018

andrewkroh Aug 2, 2018

andrewkroh Aug 2, 2018

ph commented Aug 3, 2018

ph commented Aug 3, 2018

kvch commented Aug 3, 2018

ph commented Aug 3, 2018 •

edited

Loading

ph commented Aug 3, 2018

ph commented Aug 3, 2018

		@@ -0,0 +1 @@
		{"uuid":"5c255ec6-8c55-418c-bc62-45bf3d411ed6"}

Beatless initial PR #7837

Beatless initial PR #7837

Conversation

ph commented Aug 1, 2018 • edited Loading

houndci-bot Aug 1, 2018

Choose a reason for hiding this comment

ruflin Aug 2, 2018

Choose a reason for hiding this comment

ruflin Aug 2, 2018

Choose a reason for hiding this comment

ruflin Aug 2, 2018

Choose a reason for hiding this comment

ph commented Aug 2, 2018

urso commented Aug 2, 2018

ph commented Aug 2, 2018 via email

kvch commented Aug 2, 2018

andrewkroh Aug 2, 2018

Choose a reason for hiding this comment

andrewkroh Aug 2, 2018

Choose a reason for hiding this comment

ph commented Aug 3, 2018

ph commented Aug 3, 2018

kvch commented Aug 3, 2018

ph commented Aug 3, 2018 • edited Loading

ph commented Aug 3, 2018

ph commented Aug 3, 2018

ph commented Aug 1, 2018 •

edited

Loading

ph commented Aug 3, 2018 •

edited

Loading