Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node as default metricset for munin #6767

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

ruflin
Copy link
Collaborator

@ruflin ruflin commented Apr 4, 2018

The assumption here is that the port 4949 is the default port that a local service will expose the munin protocol. And for the namespace we manually set node as the default.

@ruflin ruflin requested a review from jsoriano April 4, 2018 14:41
@ruflin ruflin mentioned this pull request Apr 4, 2018
32 tasks
period: 10s
hosts: ["localhost:4949"]
node.namespace: node
#node.namespace: node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node.namespace is required

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

This is one of these fields where I'm not sure if we should set it or not. In general we have the defaults in the reference file but already with the hosts part we break this principle. It seems more the reference file is going in the direction of "if you copy this, you have something running" which I kind of like.

The assumption here is that the port 4949 is the default port that a local service will expose the munin protocol. And for the namespace we manually set `node` as the default.
@jsoriano jsoriano merged commit ac2fd95 into elastic:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants