Set node as default metricset for munin #6767
Merged
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
jsoriano
requested changes
Apr 4, 2018
metricbeat/metricbeat.reference.yml
Outdated
| period: 10s | ||
| hosts: ["localhost:4949"] | ||
| node.namespace: node | ||
| #node.namespace: node |
There was a problem hiding this comment.
Updated
This is one of these fields where I'm not sure if we should set it or not. In general we have the defaults in the reference file but already with the hosts part we break this principle. It seems more the reference file is going in the direction of "if you copy this, you have something running" which I kind of like.
The assumption here is that the port 4949 is the default port that a local service will expose the munin protocol. And for the namespace we manually set `node` as the default.
jsoriano
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumption here is that the port 4949 is the default port that a local service will expose the munin protocol. And for the namespace we manually set
nodeas the default.