Set default metricsets in Docker module #6718
Conversation
ruflin
force-pushed
the
docker-defaults
branch
2 times, most recently
from
c2b0504 to
503974f
Compare
The following metricests are set as default: `container`, `cpu`, `diskio`, `healthcheck`, `info`, `memory` and `network`. `image` is not set as default.
|
Rebased without changelog. Changelog entry is here: #6668 (comment) and will be added as one PR in the end. |
| panic(err) | ||
| } | ||
| mb.Registry.MustAddMetricSet("docker", "image", New, | ||
| mb.WithHostParser(docker.HostParser), |
There was a problem hiding this comment.
It had no host parser before 🤔 but I guess it should have had it.
There was a problem hiding this comment.
Hm, good point. Yes it should have one.
| hosts: ["unix:///var/run/docker.sock"] | ||
| period: 10s | ||
|
|
||
| # Replace dots in labels with `_`. Set to false to keep dots | ||
| labels.dedot: true |
There was a problem hiding this comment.
This is the default, so I guess it is not needed in config.yml.
There was a problem hiding this comment.
The reason I left this in is because we plan to change the default here in 7.0. So if it is in the config most people use, 7.0 will be less breaking for existing users.
| @@ -1,13 +1,5 @@ | |||
| - module: docker | |||
| metricsets: ["container", "cpu", "diskio", "healthcheck", "info", "memory", "network"] | |||
| hosts: ["unix:///var/run/docker.sock"] | |||
There was a problem hiding this comment.
Out of the scope, but I think this should be the default.
|
@jsoriano See my comments. Let me know if you need changes or if it is ok to go. |
|
It is ok to go :) |
The following metricests are set as default:
container,cpu,diskio,healthcheck,info,memoryandnetwork.imageis not set as default.