Set all ceph metrics as default in metricbeat module #6682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
jsoriano
approved these changes
Mar 28, 2018
jsoriano
reviewed
Mar 28, 2018
| @@ -0,0 +1,5 @@ | |||
| - module: ceph | |||
| metricsets: ["cluster_disk", "cluster_health", "monitor_health", "pool_disk", "osd_tree"] | |||
There was a problem hiding this comment.
This is another example of module where we may want different default periods for different metricsets.
There was a problem hiding this comment.
good point, let me look into this. I also realised one of the metricsets is experimental so not all of them should be here (or I should set it to beta).
|
I adjusted the defaults so the disk metrics are only reported every minute. I skipped osd_df for now as this metricset needs some cleanup before going into beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.