Update golang/x/[crypto|net|sys|text|tools] dependencies

[cyrilleverrier]

Update golang/x/[crypto|net|sys|text|tools] dependencies in the vendor folder

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cyrilleverrier]

@ruflin there is a failing test in filebeat:

======================================================================
ERROR: Tests that in case of a decoding error it is handled gracefully
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/go/src/github.com/elastic/beats/filebeat/tests/system/test_harvester.py", line 811, in test_decode_error
    max_timeout=5)
  File "/go/src/github.com/elastic/beats/filebeat/tests/system/../../../libbeat/tests/system/beat/beat.py", line 319, in wait_until
    "Waited {} seconds.".format(max_timeout))
TimeoutError: Timeout waiting for 'cond' to be true. Waited 5 seconds.

When I run the test locally, I reproduce the same error.

The simplified chinese string is actually decoded successfully.
Invalid characters are replaced by the unicode \ufffd

2018-02-01T10:16:38.728+0100	DEBUG	[publish]	pipeline/processor.go:275	Publish event: {
  "@timestamp": "2018-02-01T09:16:38.728Z",
  "@metadata": {
    "beat": "filebeat",
    "type": "doc",
    "version": "7.0.0-alpha1"
  },
  "message": "\u003cmeta content=\"鐬�В銆孏oogle 鍟嗘キ瑙ｆ焙鏂规�銆嶆彁渚涚殑鍚勯�鏈嶅嫏杌熶欢濡備綍鍔╂偍鍒嗘瀽璩囨枡銆佸垔鐧诲唬鍛娿€佹彁鍗囩恫绔欐垚鏁堢瓑銆�\" name=\"description\"\u003e",
  "prospector": {
    "type": "log"
  },
  "input": {
    "type": "log"
  },
  "beat": {
    "name": "cyrille",
    "hostname": "cyrille",
    "version": "7.0.0-alpha1"
  },
  "source": "/home/cyrille/code/go/src/github.com/elastic/beats/filebeat/build/system-tests/run/test_harvester.Test.test_decode_error/log/test.log",
  "offset": 180
}

this is after upgrading golang.org/x/text/ from golang/text@2910a50 to golang/text@e19ae14

See golang/go#18898: All decoders should no longer return errors except for the opt-in error for UTF-16/32.

[cyrilleverrier]

test has been fixed and Travis is happy

[ruflin]

jenkins, test it

[ruflin]

@urso Could you have a look at the changes for the decoder?

[ruflin]

@cyrilleverrier Are the versions you picked the most recent once? I wonder as this is quite massive if we should update each dependency with a separate PR to better be able to track later some issue and nail it down to one dependency change. At the same time I'm hoping we don't hit any issues :-)

@elastic/beats Any thoughts?

[cyrilleverrier]

@ruflin I used the latest versions. I think it's more appropriate to use the release-branch.go1.9 branch, don't you think?

[ruflin]

@cyrilleverrier Yes, definitively. I didn't even know they have go specific branches.

[cyrilleverrier]

• x/net package has release branches: https://go.googlesource.com/net/

• x/tools package has release branches: https://go.googlesource.com/tools/

• x/crypto module only has master branch and no git tag: https://go.googlesource.com/crypto

• x/sys package only has master branch and no git tag: https://go.googlesource.com/sys

• x/text module only has master branch and no git tag: https://go.googlesource.com/text

[urso]

Update of x/text LGTM. Happy it was not much effort. Last time we tried it didn't go that well.

[ruflin]

jenkins, test it

[ruflin]

Change LGTM. WFG (waiting for green).

@elastic/apm-server This change might also be relevant for you.

[ruflin]

@cyrilleverrier There is one test on windows failing which might be related: https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-windows/3090/beat=filebeat,label=windows/testReport/junit/test_harvester/Test/test_decode_error/

[cyrilleverrier]

@ruflin I don't have a windows OS. Can someone else look into it ?

[ruflin]

@cyrilleverrier To move this forward, could you open 1 PR per lib update? I think the only blocking one is text. Like this we can get the other ones in quickly.

[cyrilleverrier]

Individual PR have been submitted. Closing this one.