Logstash client window size enhancement #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +72,16 @@ func newLumberjackClient( | |||
| } | |||
| } | |||
|
|
|||
| func (l *lumberjackClient) Connect(timeout time.Duration) error { | |||
There was a problem hiding this comment.
Trying to follow how this change is related to the other changes? Is this Method used? Same for close.
There was a problem hiding this comment.
Connect and Close are used by output/modes module. Just adding some debug here to better see how window size changes and reconnects/errors happen (as these are related). We re-connect on failure + we adapt window sizes on error.
|
- Have window size converge towards batch size requested to be published. If maximum batch size ever published is less then maximum allowed window size. - Always shrink window size on error. If connection was lost due to logstash closing it by internal timeouts (circuite breaker) we want to decrease the window size on next try. - Add unit tests for logstash client window sizing behavior - Add changelog entry
urso
force-pushed
the
enh/logstash-output-win-size
branch
from
bc6065b
to
b9ac89c
Compare
ruflin
added a commit
that referenced
this pull request
Dec 30, 2015
Logstash client window size enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maximum batch size ever published is less then maximum allowed window size.
closing it by internal timeouts (circuite breaker) we want to decrease
the window size on next try.