Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show config for passing credentials rather than command line #5673

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

dedemorton
Copy link
Contributor

In previous releases, we showed how to set credentials from the command line because it simplified the getting started experience, but this introduced other problems (credentials were less secure), so this PR changes the getting started docs to show how to configure credentials in the config file. This PR also fixes #4867

These changes make the asciidoc source a lot simpler because we can remove the conditional coding now that we tell everyone to use the config file.

Note that I have another PR open that affects the topic about loading dashboards: #5635

@dedemorton dedemorton added docs needs_backport PR is waiting to be backported to other branches. review labels Nov 21, 2017
@ruflin
Copy link
Contributor

ruflin commented Nov 23, 2017

@dedemorton Needs a rebase

@dedemorton dedemorton force-pushed the update_credential_docs branch from bba7af7 to 1a67231 Compare November 28, 2017 00:08
@dedemorton dedemorton force-pushed the update_credential_docs branch from 1a67231 to cc5c72a Compare November 28, 2017 00:22
@dedemorton
Copy link
Contributor Author

@ruflin I've rebased

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@ruflin ruflin merged commit 25c8fd9 into elastic:master Nov 28, 2017
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 28, 2017
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 28, 2017
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Nov 28, 2017
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants