-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show config for passing credentials rather than command line #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
added
docs
needs_backport
PR is waiting to be backported to other branches.
review
labels
Nov 21, 2017
@dedemorton Needs a rebase |
dedemorton
force-pushed
the
update_credential_docs
branch
from
November 28, 2017 00:08
bba7af7
to
1a67231
Compare
dedemorton
force-pushed
the
update_credential_docs
branch
from
November 28, 2017 00:22
1a67231
to
cc5c72a
Compare
@ruflin I've rebased |
ruflin
approved these changes
Nov 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFG
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Nov 28, 2017
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Nov 28, 2017
dedemorton
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Nov 28, 2017
ruflin
pushed a commit
that referenced
this pull request
Nov 28, 2017
ruflin
pushed a commit
that referenced
this pull request
Nov 28, 2017
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous releases, we showed how to set credentials from the command line because it simplified the getting started experience, but this introduced other problems (credentials were less secure), so this PR changes the getting started docs to show how to configure credentials in the config file. This PR also fixes #4867
These changes make the asciidoc source a lot simpler because we can remove the conditional coding now that we tell everyone to use the config file.
Note that I have another PR open that affects the topic about loading dashboards: #5635