Reduce perfmon memory allocations #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `PdhGetFormattedCounterArray` the code was allocating memory for `bufferSize` x `sizeof(PdhCounterValueItem)`, but it only needed to allocated `bufferSize`. The buffer size is provided by Windows and already accounts for the sizeof PdhCounterValueItem. Made an improvement to create regexp objects once at startup instead of on every use. Moved config validation to startup for non-wildcard counter paths. This allows the check to only be performed one time and for any errors to be returned during the config test. Fixes elastic#5035
Closed
ruflin
approved these changes
Aug 29, 2017
|
Nice fix. Merged as Windows build was green. Will this need a backport? |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Aug 29, 2017
In `PdhGetFormattedCounterArray` the code was allocating memory for `bufferSize` x `sizeof(PdhCounterValueItem)`, but it only needed to allocated `bufferSize`. The buffer size is provided by Windows and already accounts for the sizeof PdhCounterValueItem. Made an improvement to create regexp objects once at startup instead of on every use. Moved config validation to startup for non-wildcard counter paths. This allows the check to only be performed one time and for any errors to be returned during the config test. Fixes elastic#5035 (cherry picked from commit 0fc4dea)
tsg
pushed a commit
that referenced
this pull request
Aug 29, 2017
In `PdhGetFormattedCounterArray` the code was allocating memory for `bufferSize` x `sizeof(PdhCounterValueItem)`, but it only needed to allocated `bufferSize`. The buffer size is provided by Windows and already accounts for the sizeof PdhCounterValueItem. Made an improvement to create regexp objects once at startup instead of on every use. Moved config validation to startup for non-wildcard counter paths. This allows the check to only be performed one time and for any errors to be returned during the config test. Fixes #5035 (cherry picked from commit 0fc4dea)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
In `PdhGetFormattedCounterArray` the code was allocating memory for `bufferSize` x `sizeof(PdhCounterValueItem)`, but it only needed to allocated `bufferSize`. The buffer size is provided by Windows and already accounts for the sizeof PdhCounterValueItem. Made an improvement to create regexp objects once at startup instead of on every use. Moved config validation to startup for non-wildcard counter paths. This allows the check to only be performed one time and for any errors to be returned during the config test. Fixes elastic#5035 (cherry picked from commit 3931015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
PdhGetFormattedCounterArraythe code was allocating memory forbufferSizexsizeof(PdhCounterValueItem), but it only needed to allocatebufferSize. The buffer size is provided by Windows and already accounts for the sizeof PdhCounterValueItem.Made an improvement to create regexp objects once at startup instead of on every use.
Moved config validation to startup for non-wildcard counter paths. This allows the check to only be performed one time and for any errors to be returned during the config test.
Fixes #5035