Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #4964 to 6.0: Added cloud.id and cloud.auth config settings #4976

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Aug 23, 2017

Cherry-pick of PR #4964 to 6.0 branch. Original message:

This adds two new configuration settings: cloud.id and cloud.auth.
They can be used in the configuration file, or from the CLI like this:

./metricbeat -e -E cloud.id=<cloud-id> -E cloud.auth=<cloud-auth>

The ES/KB settings are changed via overwritting, but we display an INFO
level message that the settings are changed by the cloud-id.

Closes #4959.

Left TODOs:

  • more tests
  • docs for the new settings
  • changelog

@ruflin
Copy link
Contributor

ruflin commented Aug 23, 2017

jenkins, retest it

@@ -65,6 +65,8 @@ https://github.com/elastic/beats/compare/v6.0.0-beta1...master[Check the HEAD di

- Update init scripts to use the `test config` subcommand instead of the deprecated `-configtest` flag. {issue}4600[4600]
- Get by default the credentials for connecting to Kibana from the Elasticsearch output configuration. {pull}4867[4867]
- Move TCP UDP start up into `server.Start()` {pull}4903[4903]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i cleaned it.

* Added cloud.id and cloud.auth config settings

This adds two new configuration settings: `cloud.id` and `cloud.auth`.
They can be used in the configuration file, or from the CLI like this:

```
./metricbeat -e -E cloud.id=<cloud-id> -E cloud.auth=<cloud-auth>
```

The ES/KB settings are changed via overwritting, but we display an INFO
level message that the settings are changed by the cloud-id.

Closes elastic#4959.

* goimports fix

* aded more tests

* added basic docs

* changelog

* addressed comments

* Check that we're not enabling a second output

* remove unused var

* Addressed comments

(cherry picked from commit bd6981d)
@tsg tsg force-pushed the backport_4964_6.0 branch from 4457b67 to c46fc43 Compare August 23, 2017 20:14
@tsg
Copy link
Contributor Author

tsg commented Aug 23, 2017

jenkins, test it

@ruflin ruflin merged commit 490dff2 into elastic:6.0 Aug 24, 2017
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…#4976)

This adds two new configuration settings: `cloud.id` and `cloud.auth`.
They can be used in the configuration file, or from the CLI like this:

```
./metricbeat -e -E cloud.id=<cloud-id> -E cloud.auth=<cloud-auth>
```

The ES/KB settings are changed via overwritting, but we display an INFO
level message that the settings are changed by the cloud-id.

Closes elastic#4959.

* goimports fix

* aded more tests

* added basic docs

* changelog

* addressed comments

* Check that we're not enabling a second output

* remove unused var

* Addressed comments

(cherry picked from commit 3d32342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants