Modify add_docker_metadata processor to lookup ContainerId from source path in case of filebeat #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce path in case of filebeat
|
Can one of the admins verify this patch? |
|
Hi @shyamradhakrishnan, how unfortunate, just today, some hours ago, I opened this one #4495 |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically on build-eu-00. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
ooh, @exekias did not notice it on Monday and hence started working.
Please ignore, I should close this request then right?
…On 06/13/2017 08:57 PM, Carlos Pérez-Aradros Herce wrote:
Hi @shyamradhakrishnan <https://github.com/shyamradhakrishnan>, how
unfortunate, just today, some hours ago, I opened this one #4495
<#4495>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4496 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AScas8oqzZEk0a-TL8e5vHmg5mf29O2tks5sDqpFgaJpZM4N4qLF>.
|
|
If you feel that #4495 fills your needs we can close this one, anyway I'm happy to discuss the implementation there :) Also thank you for contributing, I would like to encourage you to keep doing it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add_docker_metadata processor cannot work with Filebeat because in typical docker json logs, the container id is not present. This change is to lookup the ContainerId from the source path,similar to Kubernetes processor. Being a newbie in go, please excuse if some of the usages are not per go coding standards. The solution is to basically make the "matching" for ContainerId pluggable and use a different implementation for filebeat.