Add varnishlogbeat and varnishstatbeat #4353
Conversation
|
Hi @phenomenes, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
|
@karmi email address updated |
|
Can one of the admins verify this patch? |
|
@phenomenes Thanks a lot for creating these two beats. For varnishbeat it sounds to me like it would fit perfectly into a varnish metricbeat module (which we don't have yet). For the varnishlogbeat it sounds like it could fit into filebeat. I was recently working on filebeat an restructuring it to allow also other types of prospectors. One first example here is the redis slowlog prospector: #4180 Perhaps it could also be part of filebeat in the future? Does the varnishlog have a state? |
|
@ruflin what do you mean by state? |
|
By state I mean if it keeps track somehow on until where it was reading. Like the offset in filebeat with the registry. Or how do you decide where to start reading the log after restarting the beat? |
|
It doesn't maintain state, is event based. About varnishstats I haven't fully read metricbeat code yet but I think it could fit. |
|
Means if you restart, you just start to fetch the events that are flowing from this point in time and not from the past. About the metricbeat module: It would be really great to have a contribution for a varnish module. Here is the dev guide: https://www.elastic.co/guide/en/beats/metricbeat/current/creating-metricsets.html In case you are interested, just ping me if I can help somehow ;-) |
|
that's exactly what it does, so yes, it maintains state. cool, I don't have much time right now but I'll have a look as soon as I'm free. |
|
@phenomenes About the state: I need to have a closer look into varnishlogbeat to see what the state structure is. |
|
To clarify, varnishlogbeat does not maintain state. It will always read starting from the last record, this is handled automatically by Varnish. |
|
Interesting. So if you reconnect it knows where you left off. |
No description provided.