Extract stdin prospector #4158
Merged
Extract stdin prospector #4158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This a first step in the direction of having a package for each prospector together with its harvester. Stdin prospector was tackled first as it has much less dependencies. Until the refactoring is completed there will be some duplicated code.
ruflin
force-pushed
the
extract-stdin-prospector
branch
from
4145ce2
to
29c6552
Compare
| @@ -90,6 +89,6 @@ func (o *Outlet) OnEventSignal(event *input.Data) bool { | |||
| } | |||
| } | |||
|
|
|||
| func (o *Outlet) Copy() prospector.Outlet { | |||
| func (o *Outlet) Copy() Outleter { | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported method Outlet.Copy should have comment or be unexported
| wg sync.WaitGroup | ||
| reloader *cfgfile.Reloader | ||
| once bool | ||
| beatDone chan struct{} | ||
| } | ||
|
|
||
| func New(out prospector.Outlet, prospectorConfigs []*common.Config, beatDone chan struct{}, once bool) (*Crawler, error) { | ||
| func New(out channel.Outleter, prospectorConfigs []*common.Config, beatDone chan struct{}, once bool) (*Crawler, error) { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function New should have comment or be unexported
7AC
approved these changes
May 1, 2017
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a first step in the direction of having a package for each prospector together with its harvester. Stdin prospector was tackled first as it has much less dependencies. Until the refactoring is completed there will be some duplicated code.