Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vSphere][datastore_cluster] Add support for new metrics in datastore_cluster metricset #40634

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Aug 28, 2024

Description

Here are the following metrics to be added for the datastore cluster data stream in the vSphere metricbeat module. Here we added a new performance API to get more detailed information from vSphere.

Metrics Type Metrics API Field Mappings
Datastore cluster capacity StoragePod.Summary.Capacity Summary capacity.bytes
  StoragePod.Summary.FreeSpace Summary free_space.bytes

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@kush-elastic kush-elastic requested review from a team as code owners August 28, 2024 04:54
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 28, 2024
Copy link
Contributor

mergify bot commented Aug 28, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 30-implement-the-datastore_cluster-metricset-beats-changes upstream/30-implement-the-datastore_cluster-metricset-beats-changes
git merge upstream/main
git push upstream 30-implement-the-datastore_cluster-metricset-beats-changes

Copy link
Contributor

mergify bot commented Aug 28, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kush-elastic? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

…implement-the-datastore_cluster-metricset-beats-changes
Copy link
Contributor

mergify bot commented Aug 28, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 30-implement-the-datastore_cluster-metricset-beats-changes upstream/30-implement-the-datastore_cluster-metricset-beats-changes
git merge upstream/main
git push upstream 30-implement-the-datastore_cluster-metricset-beats-changes

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 28, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 28, 2024
@pierrehilbert pierrehilbert added needs_team Indicates that the issue/PR needs a Team:* label Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Aug 28, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 28, 2024
@kush-elastic kush-elastic changed the title [vSphere][datastore_cluster] Add support for new metrics in host metricset [vSphere][datastore_cluster] Add support for new metrics in datastore_cluster metricset Aug 28, 2024
@devamanv
Copy link
Contributor

Shared a few more review comments. Rest looks good.

Copy link
Contributor

mergify bot commented Aug 31, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 30-implement-the-datastore_cluster-metricset-beats-changes upstream/30-implement-the-datastore_cluster-metricset-beats-changes
git merge upstream/main
git push upstream 30-implement-the-datastore_cluster-metricset-beats-changes

…implement-the-datastore_cluster-metricset-beats-changes
@kush-elastic kush-elastic merged commit 30320a3 into elastic:main Sep 2, 2024
29 checks passed
@ishleenk17 ishleenk17 added the backport-8.15 Automated backport to the 8.15 branch with mergify label Sep 12, 2024
mergify bot pushed a commit that referenced this pull request Sep 12, 2024
…_cluster metricset (#40634)

* initial commit for datastore cluster

* mage update

* update:
- data.json
- field.yml

* doc updates

* datastore_cluster -> datastorecluster

* resolve review comments

* fix UTs

* update URL for UTs

* update UTs

* fix field mapping

* update data.json

(cherry picked from commit 30320a3)

# Conflicts:
#	metricbeat/docs/modules/vsphere.asciidoc
#	metricbeat/docs/modules_list.asciidoc
#	metricbeat/metricbeat.reference.yml
#	metricbeat/module/vsphere/_meta/README.md
#	metricbeat/module/vsphere/_meta/config.reference.yml
#	metricbeat/module/vsphere/_meta/config.yml
#	metricbeat/module/vsphere/_meta/docs.asciidoc
#	metricbeat/module/vsphere/fields.go
#	metricbeat/modules.d/vsphere.yml.disabled
#	x-pack/metricbeat/metricbeat.reference.yml
ishleenk17 pushed a commit that referenced this pull request Sep 14, 2024
…_cluster metricset (#40634)

* initial commit for datastore cluster

* mage update

* update:
- data.json
- field.yml

* doc updates

* datastore_cluster -> datastorecluster

* resolve review comments

* fix UTs

* update URL for UTs

* update UTs

* fix field mapping

* update data.json
ishleenk17 added a commit that referenced this pull request Sep 14, 2024
…_cluster metricset (#40634) (#40829)

* initial commit for datastore cluster

* mage update

* update:
- data.json
- field.yml

* doc updates

* datastore_cluster -> datastorecluster

* resolve review comments

* fix UTs

* update URL for UTs

* update UTs

* fix field mapping

* update data.json

Co-authored-by: Kush Rana <89848966+kush-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.15 Automated backport to the 8.15 branch with mergify enhancement Metricbeat Metricbeat Module:beat The beat Metricbeat module module Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants