Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat][gcs] - Cleaned up invalid CHANGELOG entry resulting from community contribution #38512

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[filebeat][gcs] - Cleaned up invalid CHANGELOG entry resulting from community contribution #38512

merged 1 commit into from
Mar 21, 2024

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Cleanup
  • Docs

Proposed commit message

Moved bugfix CHANGELOG entry from CHANGELOG-developer.next.asciidoc to CHANGELOG.next.asciidoc

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 21, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 21, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations Team label Mar 21, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 21, 2024
@ShourieG ShourieG added docs needs_team Indicates that the issue/PR needs a Team:* label labels Mar 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 21, 2024
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label backport-v8.13.0 Automated backport with mergify labels Mar 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 21, 2024
@ShourieG ShourieG requested a review from andrewkroh March 21, 2024 11:08
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@ShourieG ShourieG added the Filebeat Filebeat label Mar 21, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@ShourieG ShourieG changed the title [filebeat][gcs] - Cleaned up CHANGELOG entry resulting from community contribution [filebeat][gcs] - Cleaned up invalid CHANGELOG entry resulting from community contribution Mar 21, 2024
@ShourieG ShourieG mentioned this pull request Mar 21, 2024
Merged
6 tasks
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 10 min 41 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @ShourieG

@ShourieG ShourieG merged commit 4b9fe7c into elastic:main Mar 21, 2024
35 of 36 checks passed
@ShourieG ShourieG deleted the gcs/asciidoc_cleanup branch March 21, 2024 12:17
mergify bot pushed a commit that referenced this pull request Mar 21, 2024
@ShourieG @mergify
fixed changelog update for gcs bugfix (#38512)
5fc750c 
(cherry picked from commit 4b9fe7c)
@mergify mergify bot mentioned this pull request Mar 21, 2024
Merged
6 tasks
ShourieG added a commit that referenced this pull request Mar 22, 2024
@mergify @ShourieG
fixed changelog update for gcs bugfix (#38512) (#38516)
f9ce8c9 
(cherry picked from commit 4b9fe7c)

Co-authored-by: ShourieG <105607378+ShourieG@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees

@ShourieG ShourieG

Labels
backport-v8.13.0 Automated backport with mergify docs Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShourieG @elasticmachine @kcreddy