Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Ignore @tmp directories in test #37677

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jan 19, 2024

Proposed commit message

Build has been failing with error:

go: warning: "./module/aws@tmp/..." matched no packages

@tmp is added by Jenkins and should not be tested.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner January 19, 2024 15:38
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 19, 2024
@botelastic
Copy link

botelastic bot commented Jan 19, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented Jan 19, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 161 min 44 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-20T03:23:01.289+0000

  • Duration: 152 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 28782
Skipped 2015
Total 30797

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kaiyan-sheng kaiyan-sheng merged commit c23411a into elastic:main Jan 22, 2024
10 checks passed
@kaiyan-sheng kaiyan-sheng deleted the fix_test branch January 22, 2024 14:15
@kaiyan-sheng kaiyan-sheng added the backport-v8.12.0 Automated backport with mergify label Jan 29, 2024
mergify bot pushed a commit that referenced this pull request Jan 29, 2024
(cherry picked from commit c23411a)

# Conflicts:
#	pytest.ini
#	x-pack/metricbeat/Jenkinsfile.yml
kaiyan-sheng added a commit that referenced this pull request Jan 29, 2024
* Ignore @tmp directories in test (#37677)

(cherry picked from commit c23411a)

# Conflicts:
#	pytest.ini
#	x-pack/metricbeat/Jenkinsfile.yml

* Update Jenkinsfile.yml

* Update pytest.ini

---------

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.12.0 Automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build 2177 for main with status FAILURE - go: warning: "./module/aws@tmp/..." matched no packages
3 participants