Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Prepare Changelog for 8.8.0 #35524

Merged
merged 7 commits into from
May 24, 2023
Merged

docs: Prepare Changelog for 8.8.0 #35524

merged 7 commits into from
May 24, 2023

Conversation

elasticmachine
Copy link
Collaborator

Prepare Changelog for 8.8.0.

Merge after first BC.

@elasticmachine elasticmachine requested a review from a team as a code owner May 22, 2023 12:50
@elasticmachine elasticmachine requested review from belimawr and rdner and removed request for a team May 22, 2023 12:50
@elasticmachine elasticmachine self-assigned this May 22, 2023
@elasticmachine elasticmachine added docs in progress Pull request is currently in progress. release automation Team:Automation Label for the Observability productivity team labels May 22, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 22, 2023
@elasticmachine elasticmachine requested a review from a team May 22, 2023 12:50
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 22, 2023
@elasticmachine
Copy link
Collaborator Author

elasticmachine commented May 22, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-24T11:21:11.645+0000

  • Duration: 9 min 31 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert
Copy link
Collaborator

There is missing release there: we can't see 8.7 and 8.7.1 in this file.
Could you integration them from https://github.com/elastic/beats/blob/main/CHANGELOG.asciidoc please?

pierrehilbert
pierrehilbert reviewed May 22, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
pierrehilbert
pierrehilbert reviewed May 22, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated
- Fix race condition when stopping runners {pull}32433[32433]
- Fix concurrent map writes when system/process code called from reporter code {pull}32491[32491]
- Fix namespacing on self-monitoring {pull}32336[32336]
- Fix concurrent map writes when system/process code called from reporter code {pull}32491[32491]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned two times

@pierrehilbert
Copy link
Collaborator

Don't forget to delete empty sections

@mergify
Copy link
Contributor

mergify bot commented May 22, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b prepare-changelog-8.8.0 upstream/prepare-changelog-8.8.0
git merge upstream/8.8
git push upstream prepare-changelog-8.8.0

@AndersonQ AndersonQ force-pushed the prepare-changelog-8.8.0 branch from b986ca8 to 877a131 Compare May 23, 2023 06:00
@pierrehilbert
Copy link
Collaborator

@kilfoyle I forgot to ping you on this one too sorry.

kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
@kilfoyle
Copy link
Contributor

Sorry for all of the suggestions. These just get the docs nice and consistent.

cmacknz
cmacknz reviewed May 23, 2023
View reviewed changes
CHANGELOG.asciidoc Outdated
Comment on lines 14 to 17
- Fix namespacing on self-monitoring {pull}32336[32336]
- Fix race condition when stopping runners {pull}32433[32433]
- Fix concurrent map writes when system/process code called from reporter code {pull}32491[32491]
- Fix namespacing on self-monitoring {pull}32336[32336]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are also old PRs that were revived by merge conflicts. The newest one in this group is from July 2022 and has already been released: #32491

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be removed entirely. Look at the PR number for an idea of how old it is. Anything that isn't at least 34xxx is suspect for this.

@mergify
Copy link
Contributor

mergify bot commented May 23, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b prepare-changelog-8.8.0 upstream/prepare-changelog-8.8.0
git merge upstream/8.8
git push upstream prepare-changelog-8.8.0

AndersonQ and others added 3 commits May 24, 2023 13:13
@AndersonQ
adjust changelog
5342b72
@AndersonQ @kilfoyle
Apply suggestions from code review
cfa02d3 
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
@AndersonQ
Merge branch '8.8' into prepare-changelog-8.8.0
682d95f
@AndersonQ AndersonQ merged commit e0f69a5 into 8.8 May 24, 2023
@AndersonQ AndersonQ deleted the prepare-changelog-8.8.0 branch May 24, 2023 11:41
@reakaleek reakaleek mentioned this pull request Jul 19, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle left review comments

@cmacknz cmacknz cmacknz left review comments

@pierrehilbert pierrehilbert pierrehilbert left review comments

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@elasticmachine elasticmachine

Labels
automation docs in progress Pull request is currently in progress. release Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elasticmachine @pierrehilbert @kilfoyle @cmacknz @AndersonQ