Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/processors/decode_cef - Fix ECS observer.ip #35149

Merged

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Apr 20, 2023

What does this PR do?

Fix the ECS output format by making observer.ip into an array of strings instead of string.

Fixes #35140

Why is it important?

Filebeat should follow the ECS definition precisely.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Local Testing

cd x-pack/filebeat && PYTEST_ADDOPTS="-k test_xpack_modules" TESTING_FILEBEAT_MODULES=cef GENERATE=true mage -v pythonIntegTest

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 20, 2023
Fix the ECS output format by making `observer.ip` into an array of strings
instead of string.

Fixes elastic#35140
@andrewkroh andrewkroh force-pushed the bugfix/fb/decode-cef-observer-ip-array branch from eccad76 to 2078b45 Compare April 20, 2023 15:08
@andrewkroh andrewkroh marked this pull request as ready for review April 20, 2023 17:01
@andrewkroh andrewkroh requested a review from a team as a code owner April 20, 2023 17:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-20T18:12:05.807+0000

  • Duration: 73 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 2883
Skipped 175
Total 3058

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
Copy link
Contributor

efd6 commented Apr 20, 2023

CHANGELOG?

@andrewkroh
Copy link
Member Author

CHANGELOG?

It has a CHANGELOG.next.asciidoc entry 👍 .

@efd6
Copy link
Contributor

efd6 commented Apr 21, 2023

I am obviously blind.

andrewkroh added a commit that referenced this pull request Apr 21, 2023
Fix the ECS output format by making `observer.ip` into an array of strings
instead of string.

Fixes #35140

(cherry picked from commit 35b2dca)
andrewkroh added a commit that referenced this pull request Apr 21, 2023
…35161)

Fix the ECS output format by making `observer.ip` into an array of strings
instead of string.

Fixes #35140

(cherry picked from commit 35b2dca)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Fix the ECS output format by making `observer.ip` into an array of strings
instead of string.

Fixes #35140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.7.0 Automated backport with mergify bug Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decode_cef Processor needs to set observer.ip as array
3 participants