-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/processors/decode_cef - Fix ECS observer.ip #35149
Merged
andrewkroh
merged 2 commits into
elastic:main
from
andrewkroh:bugfix/fb/decode-cef-observer-ip-array
Apr 20, 2023
Merged
x-pack/filebeat/processors/decode_cef - Fix ECS observer.ip #35149
andrewkroh
merged 2 commits into
elastic:main
from
andrewkroh:bugfix/fb/decode-cef-observer-ip-array
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
Filebeat
Filebeat
Team:Security-External Integrations
backport-v8.7.0
Automated backport with mergify
labels
Apr 20, 2023
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Apr 20, 2023
Fix the ECS output format by making `observer.ip` into an array of strings instead of string. Fixes elastic#35140
andrewkroh
force-pushed
the
bugfix/fb/decode-cef-observer-ip-array
branch
from
April 20, 2023 15:08
eccad76
to
2078b45
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Collaborator
efd6
approved these changes
Apr 20, 2023
CHANGELOG? |
It has a CHANGELOG.next.asciidoc entry 👍 . |
I am obviously blind. |
andrewkroh
added a commit
that referenced
this pull request
Apr 21, 2023
andrewkroh
added a commit
that referenced
this pull request
Apr 21, 2023
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Fix the ECS output format by making `observer.ip` into an array of strings instead of string. Fixes #35140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the ECS output format by making
observer.ip
into an array of strings instead of string.Fixes #35140
Why is it important?
Filebeat should follow the ECS definition precisely.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Local Testing
cd x-pack/filebeat && PYTEST_ADDOPTS="-k test_xpack_modules" TESTING_FILEBEAT_MODULES=cef GENERATE=true mage -v pythonIntegTest