-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filebeat/scripts/mage - Remove installation of journald deps from crossBuild #34939
filebeat/scripts/mage - Remove installation of journald deps from crossBuild #34939
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
…ssBuild The golang-crossbuild images contain the journald development dependencies so the build steps do not need make changes to the environment before building. Fixes elastic#34938
548a8ef
to
33fbe01
Compare
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
I didn't know we could just remove them :) |
This will help prevent merge conflicts.
What does this PR do?
The golang-crossbuild images contain the journald development dependencies so
the build steps do not need make changes to the environment before building.
Fixes #34938
Why is it important?
Packaging builds are failing.(see #34938 (comment))Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
cd filebeat; SNAPSHOT=true mage -v package
Related issues