Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/httpjson: backport configurable keep-alives #34743

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 6, 2023

What does this PR do?

This is a manual backport of #34014 tailored to 7.17.

Keep-alive options are provided for both v1 and v2 HTTPJSON, so to simplify the change the keep-alive logic is put in v2 and exported for use by v1.

Why is it important?

Customer request.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 7.17-candidate labels Mar 6, 2023
@efd6 efd6 requested a review from andrewkroh March 6, 2023 22:20
@efd6 efd6 self-assigned this Mar 6, 2023
This is a manual backport of elastic#34014 tailored to 7.17.

Keep-alive options are provided for both v1 and v2 HTTPJSON, so to
simplify the change the keep-alive logic is put in v2 and exported for
use by v1.
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-06T22:21:32.766+0000

  • Duration: 70 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 3449
Skipped 305
Total 3754

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review March 7, 2023 00:15
@efd6 efd6 requested a review from a team as a code owner March 7, 2023 00:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 022d2b0 into elastic:7.17 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.17-candidate backport-skip Skip notification from the automated backport with mergify enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants