-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Fix reload policy hash consistency, browser monitor cleanup and semaphore release #34697
Merged
emilioalvap
merged 8 commits into
elastic:main
from
emilioalvap:hb-private-location-34629
Mar 7, 2023
Merged
[Heartbeat] Fix reload policy hash consistency, browser monitor cleanup and semaphore release #34697
emilioalvap
merged 8 commits into
elastic:main
from
emilioalvap:hb-private-location-34629
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilioalvap
added
bug
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
v8.7.0
labels
Feb 28, 2023
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Feb 28, 2023
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
emilioalvap
commented
Feb 28, 2023
emilioalvap
added
the
backport-skip
Skip notification from the automated backport with mergify
label
Feb 28, 2023
Collaborator
emilioalvap
added
backport-v8.7.0
Automated backport with mergify
and removed
backport-skip
Skip notification from the automated backport with mergify
labels
Mar 2, 2023
emilioalvap
commented
Mar 6, 2023
LGTM, confirmed with local testing |
andrewvc
approved these changes
Mar 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
…up and semaphore release (#34697) * Fix reload policy hash consistency, browser monitor cleanup and semaphore release * Update x-pack/heartbeat/monitors/browser/project.go * Add changelog * Update heartbeat/scheduler/schedjob.go --------- Co-authored-by: Andrew Cholakian <andrewvc@elastic.co> (cherry picked from commit cbd1a38)
emilioalvap
added a commit
that referenced
this pull request
Mar 7, 2023
…up and semaphore release (#34697) (#34760) * Fix reload policy hash consistency, browser monitor cleanup and semaphore release * Update x-pack/heartbeat/monitors/browser/project.go * Add changelog * Update heartbeat/scheduler/schedjob.go --------- Co-authored-by: Andrew Cholakian <andrewvc@elastic.co> (cherry picked from commit cbd1a38) Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…up and semaphore release (#34697) * Fix reload policy hash consistency, browser monitor cleanup and semaphore release * Update x-pack/heartbeat/monitors/browser/project.go * Add changelog * Update heartbeat/scheduler/schedjob.go --------- Co-authored-by: Andrew Cholakian <andrewvc@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.7.0
Automated backport with mergify
bug
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
v8.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #34629.
Addresses multiple issues with private location updates:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
$: docker exec -it -u root agent watch ps -aef