Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat][gcs] - Fixed log format issues #34659

Merged
merged 2 commits into from
Feb 24, 2023
Merged

[filebeat][gcs] - Fixed log format issues #34659

merged 2 commits into from
Feb 24, 2023

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Feb 24, 2023 •
edited
Loading

Type of change

  • Bug

What does this PR do?

Enhances error logs with a more structured logging approach.

Why is it important?

Removes incorrect formats which were present in the log output.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas~~
    - [] I have made corresponding changes to the documentation
    - [] I have made corresponding change to the default configuration files
    - [] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@ShourieG ShourieG requested a review from a team as a code owner February 24, 2023 05:32
@ShourieG ShourieG requested review from belimawr and fearful-symmetry and removed request for a team February 24, 2023 05:32
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 24, 2023
@ShourieG ShourieG requested a review from a team February 24, 2023 05:33
@ShourieG ShourieG self-assigned this Feb 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 24, 2023
@ShourieG ShourieG changed the title updated logs to more structured logging methods [filebeat][gcs] - Fixed log format issues Feb 24, 2023
@ShourieG ShourieG mentioned this pull request Feb 24, 2023
Closed
6 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 24, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-24T06:56:36.188+0000

  • Duration: 46 min 22 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ShourieG
Copy link
Contributor Author

/test

@ShourieG ShourieG requested review from efd6 and andrewkroh February 24, 2023 07:49
@ShourieG ShourieG merged commit 994b94d into elastic:main Feb 24, 2023
@ShourieG ShourieG deleted the gcs/bugfix-34492 branch February 24, 2023 07:50
mergify bot pushed a commit that referenced this pull request Feb 24, 2023
@ShourieG @mergify
[filebeat][gcs] - Fixed log format issues (#34659)
41a8ff2 
* updated logs to more structured logging methods

* updated asciidoc

(cherry picked from commit 994b94d)
@mergify mergify bot mentioned this pull request Feb 24, 2023
Merged
ShourieG added a commit that referenced this pull request Feb 24, 2023
@mergify @ShourieG
[filebeat][gcs] - Fixed log format issues (#34659) (#34660)
69ca207 
* updated logs to more structured logging methods

* updated asciidoc

(cherry picked from commit 994b94d)

Co-authored-by: ShourieG <105607378+ShourieG@users.noreply.github.com>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@ShourieG @chrisberkhout
[filebeat][gcs] - Fixed log format issues (#34659)
15f21d7 
* updated logs to more structured logging methods

* updated asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr was automatically assigned from elastic/elastic-agent-data-plane

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry was automatically assigned from elastic/elastic-agent-data-plane

@efd6 efd6 Awaiting requested review from efd6

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees

@ShourieG ShourieG

Labels
8.8-candidate backport-v8.7.0 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] GCS input - invalid printf format string
3 participants
@ShourieG @elasticmachine @P1llus