Fix aws cloudwatch event identifiers #34483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
botelastic
bot
removed
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
added 2 commits
February 6, 2023 19:01
|
/test |
girodav
approved these changes
Feb 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
* keep event identifier prefix as before introducing granularity * fix ec2 add metadata to deal with new event identifier suffixed by granularity dimension * fix tests * fix comments * strict instanceID check on ec2 metadata * fix identifier matching on rds and sqs metadata * changelog (cherry picked from commit 78c035e)
aspacca
pushed a commit
that referenced
this pull request
Feb 8, 2023
* Fix aws cloudwatch event identifiers (#34483) * keep event identifier prefix as before introducing granularity * fix ec2 add metadata to deal with new event identifier suffixed by granularity dimension * fix tests * fix comments * strict instanceID check on ec2 metadata * fix identifier matching on rds and sqs metadata * changelog (cherry picked from commit 78c035e) * fix backport conflict * fix backport conflict --------- Co-authored-by: Andrea Spacca <andrea.spacca@elastic.co>
This was referenced Feb 9, 2023
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* keep event identifier prefix as before introducing granularity * fix ec2 add metadata to deal with new event identifier suffixed by granularity dimension * fix tests * fix comments * strict instanceID check on ec2 metadata * fix identifier matching on rds and sqs metadata * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
What does this PR do?
#33166 introduced support for granularity in cloudwatch metrics API calls.
we collect events identified by an ID: different metrics are merged in a single event according to the ID of the event
the mentioned PR refactored the way the ID was generated, introducing a bug that prevented different metrics to be merged in a single event.
changing the event ID also prevented the ec2 add metadata to match the metadata of an instance to a given event, losing the enrichment of an event with such metadata
we fix the ID generation, still suffixing it with the dimension of the given granularity, so that we are able to merge different metrics on the same event
we refactored the ID matching logic in the ec2 add metadata to ignore the granularity dimension suffix
Why is it important?
Checklist
- [] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs