-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Blob Storage] Allowing empty content encoding headers for system tests #34412
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add instructions to the PR description how this new behaviour was tested?
…em tests (#34412) * Allowing empty content encoding headers for system tests * update changelog
What does this PR do?
Adding a failsafe for when content encoding headers might be nil, especially for system tests.
Why is it important?
Required for Agent integration package system tests
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
Testing instructions
When creating system tests for elastic-package, we use the Azure Blob Storage emulator: https://hub.docker.com/_/microsoft-azure-storage-azurite
Unfortunately the emulator itself does not return a
ContentEncoding
header, while the Cloud API will always ensure at least a defaultoctet-stream
is added if value is nil, we need to add the possibility for the Encoding Header to not be present to be able to continue the system tests.Steps to reproduce:
docker run -p 10000:10000 mcr.microsoft.com/azure-storage/azurite azurite-blob --blobHost 0.0.0.0
go build
:https://github.com/elastic/stream
test.json
, add a JSON object on a single line, like{ "testmessage" : "success" }
stream
:./stream log --retry=30 --addr=localhost -p azureblobstorage --azure-blob-storage-port=10000 --azure-blob-storage-container=azure-container1 ./test.json
Before this PR, when we run filebeat with
./filebeat -e
it will result in a panic:However with this PR, the test will pass.