Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filebeat/input/{tcp,udp}: publish log.source details in structured form #34379

Closed
wants to merge 1 commit into from

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 25, 2023

What does this PR do?

This structures the fields of log.source with address, ip and port as available.

Why is it important?

This reduces load during ingest.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.7-candidate labels Jan 25, 2023
@efd6 efd6 requested a review from a team January 25, 2023 00:56
@efd6 efd6 self-assigned this Jan 25, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 25, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-25T21:10:16.561+0000

  • Duration: 68 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 7155
Skipped 746
Total 7901

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review January 25, 2023 03:01
@efd6 efd6 requested a review from a team as a code owner January 25, 2023 03:01
@efd6 efd6 requested review from cmacknz and leehinman and removed request for a team January 25, 2023 03:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor Author

efd6 commented Jan 25, 2023

/test

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 34371-tcp-udp upstream/34371-tcp-udp
git merge upstream/main
git push upstream 34371-tcp-udp

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6
Copy link
Contributor Author

efd6 commented Feb 7, 2023

This is waiting on ECS changes. See #34371 (comment).

@efd6 efd6 marked this pull request as draft February 7, 2023 07:31
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 34371-tcp-udp upstream/34371-tcp-udp
git merge upstream/main
git push upstream 34371-tcp-udp

1 similar comment
Copy link
Contributor

mergify bot commented Feb 5, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 34371-tcp-udp upstream/34371-tcp-udp
git merge upstream/main
git push upstream 34371-tcp-udp

@narph narph added Team:Security-Service Integrations Security Service Integrations Team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Feb 8, 2024
@efd6 efd6 closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.8-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the ingest of the source address and the source port separately
4 participants