Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat][Kubernetes] Fix scheduler and proxy dashboard #34209

Merged
merged 4 commits into from
Jan 9, 2023
Merged

[Metricbeat][Kubernetes] Fix scheduler and proxy dashboard #34209

merged 4 commits into from
Jan 9, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Jan 9, 2023

What does this PR do?

Regarding #34161, some of the visualizations on Proxy and Scheduler dashboard were using kubernetes.controllermanager.* metrics leading to empty visualizations. The only change is switching those metrics to either kubernetes.scheduler.* for Scheduler dashboard and to kubernetes.proxy.* for Proxy dashboard.

Also updated the remaining area charts to line charts. Example:
image

A visualization like the one on the right, will be similar to the one on the left in case of a rate change.

Related issues

@constanca-m constanca-m requested a review from a team as a code owner January 9, 2023 09:24
@constanca-m constanca-m requested review from gizas and devamanv and removed request for a team January 9, 2023 09:24
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @constanca-m? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@constanca-m constanca-m added bug Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 9, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-09T10:52:46.223+0000

  • Duration: 54 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 3930
Skipped 876
Total 4806

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@constanca-m constanca-m merged commit a3304c4 into elastic:main Jan 9, 2023
@constanca-m constanca-m deleted the fix-kubernetes-scheduler-proxy-dashboard branch January 16, 2023 13:48
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants