-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Salesforce] Add pagination support #34065
[Salesforce] Add pagination support #34065
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
CreatedDate is changed to LogDate in the query. Which one is most appropriate? Why ? Kindly complete the internal code review. |
Currently, in the httpjson we are not able to use the pagination + split + chain call's , we had a similar Issue(#33213) previously and we are in a chat with @ShourieG who has worked on this issue previously(#33664), He is currently looking into the issue, we have provided the required configurations to dig deep into this issue. Issue Solution -> We changed the cursor value to more reliable data that we receive in the second call(chain call) TIMESTAMP_DERIVED which is related to the value between (LogDate and LogDate + 1h) and has no relation with CreatedDate. -> We have tried data collection without split functionality it's working fine as it was used for just setting the cursor value which is now changed to TIMESTAMP_DERIVED. Also, we have updated the query to LogDate as it is more related to TIMESTAMP_DERIVED. Also, we have used the similar logic in our salesforce integration as well.
This PR is internally reviewed but as discussed here we don't have any other account as of now to provide approval, so consider this PR approved, Harnish can comment the same. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
LGTM! Approved. |
This pull request is now in conflicts. Could you fix it? 🙏
|
x-pack/filebeat/module/salesforce/logout-rest/config/logout-rest.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving.
We need to see the outcome of testcases run to resolve the SDH issue. According to the outcome, the queries may need to be modified.
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
* Add pagination support
What does this PR do?
In the current Salesforce Module in filebeat, we don’t have pagination support for all four file-sets (login-rest, logout-rest, apex-rest, setupaudittrail-rest). So if in any case, we have a response body with more than 2000 records, the next page is never called and the data will not be fetched.
Solution:
You can request the next batch of records using the provided URL with your instance and session information, and repeat until all records have been retrieved. These requests use
nextRecordsUrl
and don’t include any parameters. The final batch of records doesn’t have anextRecordsUrl
field and returntrue
value for fielddone
Ref Link for Issue: https://blog.bessereau.eu/assets/pdfs/api_rest.pdf
Why is it important?
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues