[7.17](backport #33956) filestream: fix 'requires pointer' error

[mergify]

This is an automatic backport of pull request #33956 done by Mergify.

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

[botelastic]

This pull request doesn't have a Team:<team> label.

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-12-15T14:36:11.815+0000

• Duration: 67 min 13 sec

Test stats 🧪

Test	Results
Failed	0
Passed	7070
Skipped	681
Total	7751

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/7.17/pr-33956 upstream/mergify/bp/7.17/pr-33956
git merge upstream/7.17
git push upstream mergify/bp/7.17/pr-33956

[mergify]

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

[rdner]

@belimawr could you have a look at failed tests?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[mergify]

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

[rdner]

@belimawr why did we need to make this change?

91d3180

It was not a part of the original PR and the main branch still has it unchanged

beats/filebeat/input/filestream/prospector_test.go

Lines 695 to 699 in 3cd8d81

	p := fileProspector{
	filewatcher: newMockFileWatcher(tc.events, len(tc.events)),
	identifier: mustPathIdentifier(true),
	stateChangeCloser: stateChangeCloserConfig{Renamed: true},
	}

I find this change suspicious 🙂

[mergify]

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

[belimawr]

@belimawr why did we need to make this change?

91d3180

It was not a part of the original PR and the main branch still has it unchanged

beats/filebeat/input/filestream/prospector_test.go

Lines 695 to 699 in 3cd8d81

	p := fileProspector{
	filewatcher: newMockFileWatcher(tc.events, len(tc.events)),
	identifier: mustPathIdentifier(true),
	stateChangeCloser: stateChangeCloserConfig{Renamed: true},
	}

I find this change suspicious slightly_smiling_face

newMockFileWatcher does not exist on 7.17 branch. There are more tests and more helper functions on main. I just took the easiest route to make the tests pass on 7.17, with is also the one with less changes.